[libcxx-commits] [libcxx] [libc++][test] fix redefinition of _LIBCPP_HARDENING_MODE (PR #109330)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne requested changes to this pull request.

> -D_LIBCPP_HARDENING_MODE may be set in clang config files

In what files?

> or through CXXFLAGS

I don't understand, how would they make it in the test suite because of `CXXFLAGS` (I assume you're referring to the environment variable of that name)?

I don't fully understand why you need this change yet, but my immediate reaction is that we don't want to make this change. Indeed, we want to test as closely possible to the way users will use the library, and that makes us move away from that. For instance, this could potentially hide a bug where we incorrectly define `_LIBCPP_HARDENING_MODE` when `hardening_mode` is not specified, and we wouldn't find out about this.

https://github.com/llvm/llvm-project/pull/109330