[libcxx-commits] [libcxx] [libcxx] Handle windows system error code mapping in std::error_code. (PR #93101)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne commented:

This LGTM with my few comments resolved and a release note.

About the CI issue:

> Hm. There's a new failure now...it looks like in the "generic-modules" builder, only, clang fails to emit the function definition for template <class _Ep, __enable_if_t<is_error_condition_enum<_Ep>::value, int> = 0>  _LIBCPP_HIDE_FROM_ABI error_condition(_Ep __e) _NOEXCEPT, even though it's required by __is_dne_error (or, maybe emits it under a different mangling?). Not sure why this would happen -- anyone else know what might cause this error?

I would suggest rebasing this after #107638 lands, it cleans up modules and includes a whole lot. I suspect the issue would be easier to understand after that.

https://github.com/llvm/llvm-project/pull/93101