[libcxx-commits] [libcxx] [libcxxabi] [libc++][RFC] Always define internal feature test macros (PR #89178)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 19 09:22:44 PDT 2024
================
@@ -375,10 +375,10 @@
#define _LIBCPP_AVAILABILITY_HAS_BAD_EXPECTED_ACCESS_KEY_FUNCTION _LIBCPP_INTRODUCED_IN_LLVM_19
----------------
ldionne wrote:
Not attached to this file. I would like you to perform the following manual checks on the codebase to ensure that nothing has been forgotten: For each macro that changed,
- `grep -e '<NEW MACRO NAME>' -R libcxx libcxxabi | sort | uniq` to ensure that there's no remaining incorrect usage. There's really not that many hits for this `grep` so I don't think that is going to be too time consuming.
- `grep -e '<OLD MACRO NAME>' -R libcxx libcxxabi | sort | uniq` to ensure that you renamed all the instances of the old macro
https://github.com/llvm/llvm-project/pull/89178
More information about the libcxx-commits
mailing list