[libcxx-commits] [libcxx] [libcxxabi] [libc++][RFC] Always define internal feature test macros (PR #89178)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 19 09:22:43 PDT 2024


================
@@ -399,8 +398,8 @@ inline Tp const& DoNotOptimize(Tp const& value) {
 #  define TEST_HAS_OPEN_WITH_WCHAR
 #endif
 
-#if defined(_LIBCPP_HAS_NO_INT128) || defined(_MSVC_STL_VERSION)
-#   define TEST_HAS_NO_INT128
+#if (defined(_LIBCPP_HAS_INT128) && !_LIBCPP_HAS_INT128) || defined(_MSVC_STL_VERSION)
----------------
ldionne wrote:

```suggestion
#if (defined(_LIBCPP_VERSION) && !_LIBCPP_HAS_INT128) || defined(_MSVC_STL_VERSION)
```

https://github.com/llvm/llvm-project/pull/89178


More information about the libcxx-commits mailing list