[libcxx-commits] [libcxx] [libc++] use copy_file_range for fs::copy (PR #109211)

Jannik Glückert via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 19 00:15:43 PDT 2024


Jannik2099 wrote:

Thanks!

Yeah, I forgot to slap on `-Werror` yesterday, will fix later.

Another note, how TOCTOU-safe should this be? Right now I fstat both in the copy_file_range and in the sendfile impl. If the file size changes inbetween and copy_file_range fails halfway through, this may lead to inconsistent output.

https://github.com/llvm/llvm-project/pull/109211


More information about the libcxx-commits mailing list