[libcxx-commits] [libcxx] [libcxx] Use __libcpp_verbose_abort for error messages (PR #108873)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Sep 18 06:59:46 PDT 2024
https://github.com/ldionne approved this pull request.
LGTM, but please update your PR description to avoid mentioning that `__libcpp_verbose_abort` can be overridden. Indeed, we may want to remove that capability in the future (see e.g. https://releases.llvm.org/18.1.0/projects/libcxx/docs/ReleaseNotes.html#upcoming-deprecations-and-removals).
For embedded targets, I suspect that we'd want to instead provide a way to override how logging is done more generally, not just how to "log and abort".
https://github.com/llvm/llvm-project/pull/108873
More information about the libcxx-commits
mailing list