[libcxx-commits] [libcxx] [llvm] [libc++][CI] Update to Clang-20 (PR #108761)
Hristo Hristov via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Sep 15 09:03:17 PDT 2024
================
@@ -79,25 +79,6 @@ _LIBCPP_HIDE_FROM_ABI inline constexpr bool operator==(const weekday& __lhs, con
return __lhs.c_encoding() == __rhs.c_encoding();
}
-// TODO(LLVM 20): Remove the escape hatch
-# ifdef _LIBCPP_ENABLE_REMOVED_WEEKDAY_RELATIONAL_OPERATORS
-_LIBCPP_HIDE_FROM_ABI inline constexpr bool operator<(const weekday& __lhs, const weekday& __rhs) noexcept {
- return __lhs.c_encoding() < __rhs.c_encoding();
-}
-
-_LIBCPP_HIDE_FROM_ABI inline constexpr bool operator>(const weekday& __lhs, const weekday& __rhs) noexcept {
- return __rhs < __lhs;
-}
-
-_LIBCPP_HIDE_FROM_ABI inline constexpr bool operator<=(const weekday& __lhs, const weekday& __rhs) noexcept {
- return !(__rhs < __lhs);
-}
-
-_LIBCPP_HIDE_FROM_ABI inline constexpr bool operator>=(const weekday& __lhs, const weekday& __rhs) noexcept {
- return !(__lhs < __rhs);
-}
-# endif // _LIBCPP_ENABLE_REMOVED_WEEKDAY_RELATIONAL_OPERATORS
-
----------------
Zingam wrote:
I'm not quite sure about that but I think these kind of TODOs should be done in separate PRs.
For example I have one here waiting for Clang 20: https://github.com/llvm/llvm-project/pull/101826
I think this PR should be just about updating the CI and not fixing all unrelated TODOs. Please check what was done in the past.
https://github.com/llvm/llvm-project/pull/108761
More information about the libcxx-commits
mailing list