[libcxx-commits] [libcxx] [libc++][WIP] ADL-proof `std::__wrap_iter` (PR #107766)

via libcxx-commits libcxx-commits at lists.llvm.org
Sun Sep 8 09:01:41 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff e29e7e726614d59cd5adae1f81266de947ee2f3b 77c15fc931abd2d4ce1b57faefb79e32a6f6a1fc --extensions ,h,cpp -- libcxx/test/libcxx/iterators/wrap_iter_adl.compile.pass.cpp libcxx/include/__configuration/abi.h libcxx/include/__format/buffer.h libcxx/include/__iterator/iterator_traits.h libcxx/include/__iterator/wrap_iter.h libcxx/include/__memory/pointer_traits.h libcxx/include/array libcxx/include/regex libcxx/include/span libcxx/include/string libcxx/include/string_view libcxx/include/vector libcxx/test/libcxx/iterators/contiguous_iterators.pass.cpp libcxx/test/libcxx/iterators/unwrap_iter.pass.cpp libcxx/test/std/strings/basic.string/range_concept_conformance.compile.pass.cpp libcxx/test/std/strings/basic.string/string.iterators/iterator_concept_conformance.compile.pass.cpp libcxx/test/support/nasty_string.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/__iterator/wrap_iter.h b/libcxx/include/__iterator/wrap_iter.h
index 5f6f1fe5cc..d2d4690196 100644
--- a/libcxx/include/__iterator/wrap_iter.h
+++ b/libcxx/include/__iterator/wrap_iter.h
@@ -181,11 +181,11 @@ private:
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool
   operator!=(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT {
     return !(__x == __y);
-}
-_LIBCPP_WRAP_ITER_SINGLE_TEMPLATE_HEAD
-_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool
-operator>(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter1>& __y) _NOEXCEPT {
-  return __y < __x;
+  }
+  _LIBCPP_WRAP_ITER_SINGLE_TEMPLATE_HEAD
+  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR bool
+  operator>(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter1>& __y) _NOEXCEPT {
+    return __y < __x;
 }
 
 _LIBCPP_WRAP_ITER_PAIR_TEMPLATE_HEAD

``````````

</details>


https://github.com/llvm/llvm-project/pull/107766


More information about the libcxx-commits mailing list