[libcxx-commits] [libcxx] [libc++][modules] Use submodules for stop_token (PR #107441)
via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 5 11:18:23 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Louis Dionne (ldionne)
<details>
<summary>Changes</summary>
The std_stop_token module was initially created with private headers, however it turns out that some headers under __stop_token are used outside of __stop_token (e.g. in <condition_variable>), so these must be submodules after all.
---
Full diff: https://github.com/llvm/llvm-project/pull/107441.diff
1 Files Affected:
- (modified) libcxx/include/module.modulemap (+7-7)
``````````diff
diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap
index 3abc11723a5a92..2bed6b1a90a18b 100644
--- a/libcxx/include/module.modulemap
+++ b/libcxx/include/module.modulemap
@@ -294,13 +294,13 @@ module std_stdexcept [system] {
}
module std_stop_token [system] {
header "stop_token"
- private header "__stop_token/atomic_unique_lock.h"
- private header "__stop_token/intrusive_list_view.h"
- private header "__stop_token/intrusive_shared_ptr.h"
- private header "__stop_token/stop_callback.h"
- private header "__stop_token/stop_source.h"
- private header "__stop_token/stop_state.h"
- private header "__stop_token/stop_token.h"
+ module atomic_unique_lock { header "__stop_token/atomic_unique_lock.h" }
+ module intrusive_list_view { header "__stop_token/intrusive_list_view.h" }
+ module intrusive_shared_ptr { header "__stop_token/intrusive_shared_ptr.h" }
+ module stop_callback { header "__stop_token/stop_callback.h" }
+ module stop_source { header "__stop_token/stop_source.h" }
+ module stop_state { header "__stop_token/stop_state.h" }
+ module stop_token { header "__stop_token/stop_token.h" }
export *
}
module std_streambuf [system] {
``````````
</details>
https://github.com/llvm/llvm-project/pull/107441
More information about the libcxx-commits
mailing list