[libcxx-commits] [libcxx] [libcxx] improves diagnostics for containers with bad value types (PR #106296)

[Louis Dionne via libcxx-commits]

================
@@ -1024,6 +1029,15 @@ template <class _Key,
           class _Pred  = equal_to<_Key>,
           class _Alloc = allocator<pair<const _Key, _Tp> > >
 class _LIBCPP_TEMPLATE_VIS unordered_map {
+  // TODO(#106635): replace with _LIBCPP_CHECK_CONTAINER_VALUE_TYPE_REQUIREMENTS
+  // Remember to remove relevant headers when this is completed.
----------------
ldionne wrote:

I read the description of https://github.com/microsoft/STL/pull/3660 and it looks like the Standard does allow these types to be used. If that's the case, then https://github.com/llvm/llvm-project/issues/106635 should be closed until we have a LWG issue or a paper that changes the Standard, and these TODOs should be removed since we won't be able to address them.

Note that I have no love for reference types in these locations, but I also want to avoid adding non-actionable TODOs.

https://github.com/llvm/llvm-project/pull/106296