[libcxx-commits] [libcxx] [libcxx] Remove xfails due to picolibc's support for char16_t and char32_t (PR #114422)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 31 09:05:04 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Victor Campos (vhscampos)

<details>
<summary>Changes</summary>

picolibc recently
([link](https://github.com/picolibc/picolibc/commit/f6f68758fe2aa62854f49b90c3daeeb08242b512)) added support for char16_t and char32_t.

These xfails aren't needed anymore.

---
Full diff: https://github.com/llvm/llvm-project/pull/114422.diff


2 Files Affected:

- (modified) libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp (-3) 
- (modified) libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp (-3) 


``````````diff
diff --git a/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp b/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp
index a1560c8ee5853c..2b64554666817d 100644
--- a/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/uchar_h.compile.pass.cpp
@@ -11,9 +11,6 @@
 // Apple platforms don't provide <uchar.h> yet, so these tests fail.
 // XFAIL: target={{.+}}-apple-{{.+}}
 
-// mbrtoc16 not defined.
-// XFAIL: LIBCXX-PICOLIBC-FIXME
-
 // <uchar.h>
 
 #include <uchar.h>
diff --git a/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp b/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp
index 2076384deb2b23..db00cbde333658 100644
--- a/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp
+++ b/libcxx/test/std/strings/c.strings/cuchar.compile.pass.cpp
@@ -11,9 +11,6 @@
 // Apple platforms don't provide <uchar.h> yet, so these tests fail.
 // XFAIL: target={{.+}}-apple-{{.+}}
 
-// mbrtoc16 not defined.
-// XFAIL: LIBCXX-PICOLIBC-FIXME
-
 // <cuchar>
 
 #include <cuchar>

``````````

</details>


https://github.com/llvm/llvm-project/pull/114422


More information about the libcxx-commits mailing list