[libcxx-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

[Felipe de Azevedo Piovezan via libcxx-commits]

felipepiovezan wrote:

Hi @vogelsgesang , the test you added on this PR breaks the LLDB matrix bot, in particular it breaks the 15 & 17 clang tests. Could you add a `skipIf` annotation if this test is only supposed to pass when working with newer versions of libcxx/clang? https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/912/execution/node/107/log/

15 error:
```
/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/libcxx-internals-recognizer/main.cpp:29:3: error: no member named 'sort' in namespace 'std::ranges'; did you mean 'std::sort'?
  std::ranges::sort(vec.begin(), vec.end(), ranges_sort_less);
  ^~~~~~~~~~~~~~~~~
  std::sort
/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/clang_1501_build/include/c++/v1/__algorithm/sort.h:693:6: note: 'std::sort' declared here
void sort(_RandomAccessIterator __first, _RandomAccessIterator __last, _Comp __comp) {
     ^
/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/libcxx-internals-recognizer/main.cpp:32:36: error: no member named 'views' in namespace 'std::ranges'
  for (auto x : vec | std::ranges::views::transform(view_transform)) {
                      ~~~~~~~~~~~~~^
2 errors generated.
make: *** [main.o] Error 1

```

17 error:

```
FAIL: test_frame_recognizer (TestLibcxxInternalsRecognizer.LibCxxInternalsRecognizerTestCase)
   Test that implementation details of libc++ are hidden
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/test/API/lang/cpp/libcxx-internals-recognizer/TestLibcxxInternalsRecognizer.py", line 60, in test_frame_recognizer
    self.assertIn(
AssertionError: 'ranges::__sort::operator()' not found in 'std::__1::__wrap_iter<int*> std::__1::ranges::__sort::__fn::operator()[abi:ue170006]<std::__1::__wrap_iter<int*>, std::__1::__wrap_iter<int*>, bool (*)(int, int), std::__1::identity>(std::__1::__wrap_iter<int*>, std::__1::__wrap_iter<int*>, bool (*)(int, int), std::__1::identity) const'
Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/clang_1706_build/bin/clang
```


https://github.com/llvm/llvm-project/pull/108870