[libcxx-commits] [libcxx] f4db221 - [libc++][test] Use `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` for `-Wno-psabi` (#113608)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 25 11:12:44 PDT 2024


Author: Stephan T. Lavavej
Date: 2024-10-25T11:12:41-07:00
New Revision: f4db221258cb44a8f9804ce852c0403328de39b2

URL: https://github.com/llvm/llvm-project/commit/f4db221258cb44a8f9804ce852c0403328de39b2
DIFF: https://github.com/llvm/llvm-project/commit/f4db221258cb44a8f9804ce852c0403328de39b2.diff

LOG: [libc++][test] Use `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` for `-Wno-psabi` (#113608)

MSVC doesn't understand `-Wno-psabi`, which was introduced here by
@ldionne in #106077.

Using `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` (implemented by
#75317) avoids passing this to MSVC.

Added: 
    

Modified: 
    libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
index 5130758d5efd52..abb12d6a3c2473 100644
--- a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
+++ b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
@@ -18,7 +18,7 @@
 
 // Ignore diagnostic about vector types changing the ABI on some targets, since
 // that is irrelevant for this test.
-// ADDITIONAL_COMPILE_FLAGS: -Wno-psabi
+// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-psabi
 
 #include <atomic>
 #include <cassert>


        


More information about the libcxx-commits mailing list