[libcxx-commits] [libcxx] [libcxx] Add testing configuration for GPU targets (PR #104515)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 22 06:34:39 PDT 2024


================
@@ -30,3 +30,7 @@ config.substitutions.append(('%{target-include-dir}', '@LIBCXX_TESTING_INSTALL_P
 config.substitutions.append(('%{lib-dir}', '@LIBCXX_TESTING_INSTALL_PREFIX@/@LIBCXX_INSTALL_LIBRARY_DIR@'))
 config.substitutions.append(('%{module-dir}', '@LIBCXX_TESTING_INSTALL_PREFIX@/@LIBCXX_INSTALL_MODULES_DIR@'))
 config.substitutions.append(('%{test-tools-dir}', '@LIBCXX_TEST_TOOLS_PATH@'))
+
+# Available if building libc++ on top of llvm-libc.
+config.substitutions.append(('%{libc-dir}', '@LIBCXX_LIBC_LIBRARY_DIR@'))
+config.substitutions.append(('%{libc-include-dir}', '@LIBCXX_LIBC_INCLUDE_DIR@'))
----------------
ldionne wrote:

Either way is fine by me. I care mostly that the general-purpose libc++ configuration doesn't get impacted by this complexity, and on the side I'm trying to vouch for naive users trying to just do a hello world. I think the `ADDITIONAL_PARAMETERs` approach above is also acceptable in the meantime just to unblock you.

I think `-gpustartfiles` might be the better approach, but I'm not strongly attached to it. If you want to use `ADDITIONAL_PARAMETERS` for now, that's fine by me too.

https://github.com/llvm/llvm-project/pull/104515


More information about the libcxx-commits mailing list