[libcxx-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 22 04:01:39 PDT 2024


mstorsjo wrote:

> > > It's my understanding that text=auto does not override core.autocrlf. As far as I can tell from the documentation it honours the user's configuration for core.eol in combination with core.autocrlf - from git config --help:
> 
> > This doesn't match my experience.
> 
> I think this is due to a subtly of config. Setting `core.autocrlf` to `false` doesn't actually do anything since it's the default. 

It most definitely does something. Please have another look at https://github.com/mstorsjo/llvm-project/commit/inspect-newlines and the output of the log at https://github.com/mstorsjo/llvm-project/actions/runs/11407224268/job/31742748818.

First we do a checkout without setting anything. We get files with CRLF. Then we set `core.autocrlf` to `false`, which is the common way of dealing with this, then we do another checkout, and we get files with LF.

Do you dispute the above?

https://github.com/llvm/llvm-project/pull/86318


More information about the libcxx-commits mailing list