[libcxx-commits] [libc] [libcxx] [llvm] [libcxx][libc] Hand in Hand PoC with from_chars (PR #91651)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne approved this pull request.

LGTM with a few comments about the ABI boundary. I'm not overly attached to those, but I do think that avoiding the external template instantiation declaration and the explicit template instantiation in the `.cpp` file results in simpler code for the reader -- it's not always obvious how that stuff interacts with attributes.

@h-vetinari 's comment on the status page should also be addressed.

Thanks a lot to everyone involved in this patch! It's exciting to see this kind of collaboration between different subprojects.

https://github.com/llvm/llvm-project/pull/91651