[libcxx-commits] [libcxx] [libc++] Remove obsolete Appveyor files (PR #112744)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 17 09:30:25 PDT 2024


https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/112744

We don't use Appveyor to run Windows CI anymore (in fact I don't know if we ever did). Our full Windows CI setup is based on Github actions, so these files are effectively dead code.

>From fe173cf754caa1e14da048ab5eeb66804f1941d0 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Thu, 17 Oct 2024 12:29:04 -0400
Subject: [PATCH] [libc++] Remove obsolete Appveyor files

We don't use Appveyor to run Windows CI anymore (in fact I don't know
if we ever did). Our full Windows CI setup is based on Github actions,
so these files are effectively dead code.
---
 libcxx/appveyor-reqs-install.cmd | 53 ------------------------
 libcxx/appveyor.yml              | 71 --------------------------------
 2 files changed, 124 deletions(-)
 delete mode 100644 libcxx/appveyor-reqs-install.cmd
 delete mode 100644 libcxx/appveyor.yml

diff --git a/libcxx/appveyor-reqs-install.cmd b/libcxx/appveyor-reqs-install.cmd
deleted file mode 100644
index e3bd018dd3742e..00000000000000
--- a/libcxx/appveyor-reqs-install.cmd
+++ /dev/null
@@ -1,53 +0,0 @@
- at echo on
-
-if NOT EXIST C:\projects\deps (
-  mkdir C:\projects\deps
-)
-cd C:\projects\deps
-
-::###########################################################################
-:: Setup Compiler
-::###########################################################################
-if NOT EXIST llvm-installer.exe (
-  appveyor DownloadFile https://prereleases.llvm.org/win-snapshots/LLVM-9.0.0-r357435-win32.exe -FileName llvm-installer.exe
-)
-if "%CLANG_VERSION%"=="ToT" (
-    START /WAIT llvm-installer.exe /S /D=C:\"Program Files\LLVM"
-)
-if DEFINED CLANG_VERSION  @set PATH="C:\Program Files\LLVM\bin";%PATH%
-if DEFINED CLANG_VERSION  clang-cl -v
-
-if DEFINED MINGW_PATH rename "C:\Program Files\Git\usr\bin\sh.exe" "sh-ignored.exe"
-if DEFINED MINGW_PATH @set "PATH=%PATH:C:\Program Files (x86)\Git\bin=%"
-if DEFINED MINGW_PATH @set "PATH=%PATH%;%MINGW_PATH%"
-if DEFINED MINGW_PATH g++ -v
-
-::###########################################################################
-:: Install a recent CMake
-::###########################################################################
-if NOT EXIST cmake (
-  appveyor DownloadFile https://cmake.org/files/v3.7/cmake-3.7.2-win64-x64.zip -FileName cmake.zip
-  7z x cmake.zip -oC:\projects\deps > nul
-  move C:\projects\deps\cmake-* C:\projects\deps\cmake
-  rm cmake.zip
-)
- at set PATH=C:\projects\deps\cmake\bin;%PATH%
-cmake --version
-
-::###########################################################################
-:: Install Ninja
-::###########################################################################
-if NOT EXIST ninja (
-  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip -FileName ninja.zip
-  7z x ninja.zip -oC:\projects\deps\ninja > nul
-  rm ninja.zip
-)
- at set PATH=C:\projects\deps\ninja;%PATH%
-ninja --version
-
-::###########################################################################
-:: Setup the cached copy of LLVM
-::###########################################################################
-git clone --depth=1 http://llvm.org/git/llvm.git
-
- at echo off
diff --git a/libcxx/appveyor.yml b/libcxx/appveyor.yml
deleted file mode 100644
index 8a69cb9e7dde0e..00000000000000
--- a/libcxx/appveyor.yml
+++ /dev/null
@@ -1,71 +0,0 @@
-version: '{build}'
-
-shallow_clone: true
-
-build:
-  verbosity: detailed
-
-configuration:
-  - Debug
-
-environment:
-  matrix:
-    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-      CMAKE_OPTIONS: -DCMAKE_C_COMPILER=clang-cl.exe -DCMAKE_CXX_COMPILER=clang-cl.exe
-      CLANG_VERSION: ToT
-      MSVC_SETUP_PATH: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat
-      MSVC_SETUP_ARG: x86
-      GENERATOR: Ninja
-      MAKE_PROGRAM: ninja
-      APPVEYOR_SAVE_CACHE_ON_ERROR: true
-# TODO: Maybe re-enable this configuration? Do we want to support MSVC 2015's runtime?
-#    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-#      MINGW_PATH: C:\mingw-w64\i686-6.3.0-posix-dwarf-rt_v5-rev1\mingw32\bin
-#      GENERATOR: MinGW Makefiles
-#      MAKE_PROGRAM: mingw32-make
-#      APPVEYOR_SAVE_CACHE_ON_ERROR: true
-
-install:
-  ############################################################################
-  # All external dependencies are installed in C:\projects\deps
-  ############################################################################
-  - call "%APPVEYOR_BUILD_FOLDER%\\appveyor-reqs-install.cmd"
-
-before_build:
-  - if DEFINED MSVC_SETUP_PATH call "%MSVC_SETUP_PATH%" %MSVC_SETUP_ARG%
-  - cd %APPVEYOR_BUILD_FOLDER%
-
-build_script:
-  - md C:\projects\build-libcxx
-  - cd C:\projects\build-libcxx
-  - echo %configuration%
-
-  #############################################################################
-  # Configuration Step
-  #############################################################################
-  - cmake -G "%GENERATOR%" %CMAKE_OPTIONS%
-    "-DCMAKE_BUILD_TYPE=%configuration%"
-    "-DLLVM_PATH=C:\projects\deps\llvm"
-    -DLLVM_LIT_ARGS="-v --show-xfail --show-unsupported"
-    %APPVEYOR_BUILD_FOLDER%
-
-  #############################################################################
-  # Build Step
-  #############################################################################
-  - "%MAKE_PROGRAM%"
-
-test_script:
-  - "%MAKE_PROGRAM% check-cxx"
-
-on_failure:
-  - appveyor PushArtifact CMakeFiles/CMakeOutput.log
-  - appveyor PushArtifact CMakeFiles/CMakeError.log
-
-artifacts:
-  - path: '_build/CMakeFiles/*.log'
-    name: logs
-
-cache:
- - C:\projects\deps\ninja
- - C:\projects\deps\cmake
- - C:\projects\deps\llvm-installer.exe



More information about the libcxx-commits mailing list