[libcxx-commits] [libcxx] [libcxx] Provide locale conversions to tests through lit substitution (PR #105651)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 17 07:52:14 PDT 2024


================
@@ -80,6 +49,12 @@ std::wstring negate_en_US(std::wstring s) {
 #endif
 }
 
+wchar_t thousands_sep_or_default(std::wstring s) { return !s.empty() ? s[0] : L','; }
----------------
ldionne wrote:

Is there a reason why the test suite doesn't always provide the thousands separator? If we're going through the trouble of figuring those out, wouldn't it make sense to always provide the define so the code doesn't have to use `thousands_sep_or_default`?

https://github.com/llvm/llvm-project/pull/105651


More information about the libcxx-commits mailing list