[libcxx-commits] [libcxx] [libc++] Fix `reverse_iterator` when underlying is c++20 `bidirectional_iterator` but not `Cpp17BidirectionalIterator` (PR #112100)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Oct 15 06:29:45 PDT 2024
================
@@ -24,6 +24,54 @@
#include "test_macros.h"
+#if TEST_STD_VER >= 20
+template <class It>
+class cpp20_bidirectional_iterator_with_arrow {
----------------
ldionne wrote:
```suggestion
// C++20 bidirectional_iterator that does not satisfy the Cpp17BidirectionalIterator named requirement.
template <class It>
class cpp20_bidirectional_iterator_with_arrow {
```
That way, it's less likely that a future refactoring will accidentally remove the test coverage by making this a Cpp17BidirectionalIterator.
https://github.com/llvm/llvm-project/pull/112100
More information about the libcxx-commits
mailing list