[libcxx-commits] [libcxx] [libc++] Mark std::unique_ptr::release() as nodiscard (PR #110847)

[Alexander Kornienko via libcxx-commits]

alexfh wrote:

I could try running it on the larger codebase to see how frequently this fires, but we definitely would see all issues from Chromium, Skia and boringssl mentioned above. That would already be a show stopper for us, I'm afraid =\

However, if [[nodiscard]] doesn't affect ABI (which I believe should be the case), this could be an opt-in "hardening". Did you consider this option?

https://github.com/llvm/llvm-project/pull/110847