[libcxx-commits] [libcxxabi] [libc++abi] Remove unused LIBCXXABI_LIBCXX_INCLUDES CMake option (PR #111824)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 10 05:09:04 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxxabi

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

This hasn't been used for several years, so it's effectively dead code at this point.

---
Full diff: https://github.com/llvm/llvm-project/pull/111824.diff


1 Files Affected:

- (modified) libcxxabi/CMakeLists.txt (-5) 


``````````diff
diff --git a/libcxxabi/CMakeLists.txt b/libcxxabi/CMakeLists.txt
index 43400c6e8d9af1..ac1ee69d5f11c9 100644
--- a/libcxxabi/CMakeLists.txt
+++ b/libcxxabi/CMakeLists.txt
@@ -131,11 +131,6 @@ if (NOT LIBCXXABI_ENABLE_SHARED AND NOT LIBCXXABI_ENABLE_STATIC)
   message(FATAL_ERROR "libc++abi must be built as either a shared or static library.")
 endif()
 
-# TODO: Remove this, which shouldn't be necessary since we know we're being built
-#       side-by-side with libc++.
-set(LIBCXXABI_LIBCXX_INCLUDES "" CACHE PATH
-    "Specify path to libc++ includes.")
-
 set(LIBCXXABI_HERMETIC_STATIC_LIBRARY_DEFAULT OFF)
 if (WIN32)
   set(LIBCXXABI_HERMETIC_STATIC_LIBRARY_DEFAULT ON)

``````````

</details>


https://github.com/llvm/llvm-project/pull/111824


More information about the libcxx-commits mailing list