[libcxx-commits] [libcxx] [libc++][test] fix redefinition of _LIBCPP_HARDENING_MODE (PR #109330)

[Louis Dionne via libcxx-commits]

ldionne wrote:

Ack, thanks for the context. I'm not sure what to say other than repeat that the supported way to set the default hardening mode in libc++ is to set `-DLIBCXX_HARDENING_MODE=<mode>` when configuring the library, which ends up generating the `__config_site` accordingly. You could also generate `__config_site` yourself, but I'd recommend against that since that'll be one additional custom thing to maintain.

We could also look into moving the whole `__config_site` mechanism to a different mechanism like these configuration files used by Clang, but I'm not certain there's a lot of value to be gained (for libc++) from doing that.

I'm going to tentatively close this since I don't think we want to move forward with this approach as-is, but feel free to reopen if there's more discussion to be had. I'm mostly trying to keep our (long!) review queue tidy.

https://github.com/llvm/llvm-project/pull/109330