[libcxx-commits] [libcxx] [libc++][CMake] Adds option to disable clang-tidy. (PR #95654)

[Louis Dionne via libcxx-commits]

ldionne wrote:

> This option is mainly intended as an escape hatch when auto detection fails. I still feel we should fix those issues; however at the moment when somebody encounters the situation they are blocked from testing libc++.

IMO we should consider such failures as a priority and fix them -- we should aim for people not to disable these checks instead. That's the reason for my pushback on this patch. Also, since I don't know what the reports for `clang-tidy` not working were, I don't know what we're working around concretely. Do you still feel that this patch is worth pursuing?

https://github.com/llvm/llvm-project/pull/95654