[libcxx-commits] [libcxx] [libc++] Add exception guard for vector<bool>::__init_with_sentinel (PR #115491)
Peng Liu via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Nov 26 13:42:16 PST 2024
================
@@ -0,0 +1,130 @@
+//===----------------------------------------------------------------------===//
----------------
winner245 wrote:
Oops, I should have noticed this file earlier—it would have simplified my PR.
I just quickly reviewed this file `libcxx/test/std/containers/sequences/vector.bool/ctor_exceptions.pass.cpp` and found it has similarly flaw as in the exception test for `std::vector`: the same `Allocator` class is used in `ctor_exceptions.pass.cpp` does not trigger exception at all, making some tests checking for nothing for `std::vector<bool>`. Also, this test file also provided duplicate definitions for the `Allocator` and `Iterator` classes. I believe we still need to refactor these common classes into a file such as `libcxx/test/std/containers/sequences/vector/common.h`, as you suggested earlier. I will work on this first.
https://github.com/llvm/llvm-project/pull/115491
More information about the libcxx-commits
mailing list