[libcxx-commits] [libcxx] [libc++][safety] Enhance exception safety for vector assignments in reallocation scenarios (PR #117516)

[Louis Dionne via libcxx-commits]

ldionne wrote:

Thanks a lot for the detailed and clear explanation of the changes, and for the comprehensive tests you added. This contribution is of a high quality (like your recent ones), and I want to acknowledge that.

Independently of that, I am not certain that it makes sense for us to guarantee more than the basic exception safety during assignment, for reasons similar to the ones stated by Stephan in https://github.com/microsoft/STL/issues/5106. That being said, I'd like to land your other exception-related patches for `vector` first and then come back to this one with fewer intermediate patches in flight so we can really evaluate this change for what it is.

https://github.com/llvm/llvm-project/pull/117516