[libcxx-commits] [libcxx] [libc++] Complete `<charconv>` for 64-bit `long double` platforms (PR #117125)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 21 05:42:11 PST 2024


https://github.com/philnik777 requested changes to this pull request.

I'm not convinced this is a good idea. We're essentially adding a bunch of conditionals where we should really just implement the `long double` overload. Also, IMO we should just provide the symbol for `long double` on every platform and not just on ones where `long double` and `double` have different representations. It's not like we're saving much by providing it only sometimes.

https://github.com/llvm/llvm-project/pull/117125


More information about the libcxx-commits mailing list