[libcxx-commits] [libcxx] [libc++] Refactor vector move constructor with allocator (PR #116449)

Peng Liu via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 18 07:45:39 PST 2024


winner245 wrote:

> Does this patch add an exception guard that wasn't there before? If so, are we fixing an exception safety issue that we were not handling before? If that's the case, this needs a test.

The exception guard was there before, but the guard was applied around an `assign` call, which is more verbose than directly calling `__init_with_size` which has an internal exception guard already. So exception tests available in `/vector/vector.cons/exceptions.pass.cpp` also already covered this constructor. 

https://github.com/llvm/llvm-project/pull/116449


More information about the libcxx-commits mailing list