[libcxx-commits] [libcxx] [libcxxabi] [llvm] [libc++] Implement library support for MCF thread model (PR #116550)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 18 01:24:03 PST 2024


frederick-vs-ja wrote:

> What's the limit of characters perline in llvm? I see some errors from clang-format but not all of them are about my changes. I usually hard-wrap lines around 80 (mostly before, sometimes after) however in llvm there are much longer lines, around 120 characters.

In libc++ the limit is 120. (Although the limit is 80 for some files under `/llvm`, which is inconsistent.)

> There was a test that timed which I have no idea at the moment: https://github.com/llvm/llvm-project/actions/runs/11884156644/job/33112784777?pr=116550#step:4:4140
> (Is it about MSVC? then how does it run on self-hosted Linux?)

This error doesn't always occurs. It seems that the error is sometimes ignored when merging.

The test doesn't require MSVC. The name was because of that the test was cloned from [MSVC STL's corresponding test](https://github.com/microsoft/STL/tree/44a276fdff3463f7e0ab547458850c16925cab06/tests/std/tests/P0067R5_charconv).

https://github.com/llvm/llvm-project/pull/116550


More information about the libcxx-commits mailing list