[libcxx-commits] [libcxx] [libc++] Define all CMake configuration features in the same location (PR #115361)

[Louis Dionne via libcxx-commits]

ldionne wrote:

@Caslyn 

> It sounds like this change possibly triggered something that was broken with how `google-benchmark` is configured:

I am seeing this in your error message, which seems to be the problem:
```
CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
```

I guess just using `ninja` doesn't resolve to anything in your setup, so you'd need to set `CMAKE_MAKE_PROGRAM` to let CMake know where to use `ninja` from (e.g. `xcrun --find ninja`).

@vvereschaka 

> UPDATE: unfortunately passing `LIBCXX_INCLUDE_BENCHMARKS=OFF` to CMake configuration does not fix the problem.

Can you try doing a clean build? We definitely don't try to configure GoogleBenchmarks if `LIBCXX_INCLUDE_BENCHMARKS` is `OFF`: https://github.com/llvm/llvm-project/blob/0fd6f684b9c84c32d6cbfd9742402e788b2879f1/libcxx/test/CMakeLists.txt#L65

Can you share more context around the failure you're still seeing?

https://github.com/llvm/llvm-project/pull/115361