[libcxx-commits] [libcxx] [libc++][Android] Allow testing libc++ with clang-r536225 (PR #116149)

[Louis Dionne via libcxx-commits]

================
@@ -73,7 +73,15 @@ typedef void (*FunctionPtr)();
 int main(int, char**)
 {
     test_is_array<char[3]>();
+    // Android clang-r536225 identifies as clang-19.0, but it predates the
+    // LLVM 19.0.0 release. It lacks llvm.org/pr86652, which changed __is_array
+    // to return false for T[0]. llvm.org/pr93037 relies on that change for
+    // correct handling of std::is_array<T[0]>. This test will pass as long as
+    // Clang and libc++ come from the same LLVM commit, but we can't detect that
+    // here.
+#if !defined(__ANDROID__) || __clang_major__ != 19 || __clang_minor__ != 0
----------------
ldionne wrote:

Can you use `TEST_CLANG_VER` instead? I think we're more likely to grep for that and eventually remove it than `__clang_major__`.

https://github.com/llvm/llvm-project/pull/116149