[libcxx-commits] [libcxx] [libc++][NFC] Remove unused functions from <__split_buffer> (PR #115735)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 12 13:55:55 PST 2024


philnik777 wrote:

> Can you validate that these methods are unused by e.g. adding a static assertion in them? LGTM if they are truly unused.
> 
> I know that `std::deque` uses this as an implementation detail for mapping segments. Would we benefit from calling `reserve` in some cases in that implementation?

I've checked manually and couldn't find any references. If there is a use-case for `reserve` in  `deque` we can still implement a working version later (the current one is actually broken).

https://github.com/llvm/llvm-project/pull/115735


More information about the libcxx-commits mailing list