[libcxx-commits] [libcxx] [libc++] Add input validation for set_intersection() in debug mode. (PR #101508)

[Iuri Chaer via libcxx-commits]

ichaer wrote:

> Please ping us when you're ready for someone to take another look!

@ldionne, I think this is good for a new pass, the only thing making me unsure is this CI failure on the [macos (generic-cxx23, macos-latest)](https://github.com/llvm/llvm-project/actions/runs/11784259184/job/32823867124?pr=101508#logs) job, it looks unrelated... I went through a few of the errors, the one for `build/generic-cxx23/libcxx/test/libcxx/clang_modules_include.gen.py/cctype.compile.pass.cpp` looks particularly convincing, I don't think there is a way in which the changes from this MR could have affected that. The comment in that file about issues with localisation looks relevant to the error message:
```
2024-11-12T04:54:47.5099180Z # | /Users/runner/work/llvm-project/llvm-project/build/generic-cxx23/libcxx/test-suite-install/include/c++/v1/__locale_dir/support/bsd_like.h:140:91: error: use of undeclared identifier 'MB_CUR_MAX_L'
```

I may be wrong, though, and I wouldn't want for you to spend time on this if you think I may have caused it. Let me know what you think, I can dig deeper if you believe these changes may have caused it.

https://github.com/llvm/llvm-project/pull/101508