[libcxx-commits] [libcxx] [libc++] Amend error message for _LIBCPP_HAS_THREAD_API_EXTERNAL (PR #115774)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 11 13:57:05 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Caslyn Tonelli (Caslyn)

<details>
<summary>Changes</summary>

Noticed this while debugging a few things following https://github.com/llvm/llvm-project/pull/112094. Amended error message to reflect conditional check.

---
Full diff: https://github.com/llvm/llvm-project/pull/115774.diff


1 Files Affected:

- (modified) libcxx/include/__config (+1-1) 


``````````diff
diff --git a/libcxx/include/__config b/libcxx/include/__config
index a2a1aa2b2978df..9db00cd0c9fb93 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -858,7 +858,7 @@ typedef __char32_t char32_t;
 #  endif
 
 #  if !_LIBCPP_HAS_THREADS && _LIBCPP_HAS_THREAD_API_EXTERNAL
-#    error _LIBCPP_HAS_THREAD_API_EXTERNAL may not be true when _LIBCPP_HAS_THREADS is true.
+#    error _LIBCPP_HAS_THREAD_API_EXTERNAL may only be true when _LIBCPP_HAS_THREADS is true.
 #  endif
 
 #  if !_LIBCPP_HAS_MONOTONIC_CLOCK && _LIBCPP_HAS_THREADS

``````````

</details>


https://github.com/llvm/llvm-project/pull/115774


More information about the libcxx-commits mailing list