[libcxx-commits] [libcxx] Optimize __assign_with_sentinel in std::vector (PR #113852)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 11 13:39:47 PST 2024


https://github.com/philnik777 requested changes to this pull request.

The implementation itself LGTM, but I think we want to rework the benchmarks. I'd also like to see the actual benchmark results and would rather have some text in the commit message than graphics, since I don't think the graphics will show anywhere except on GitHub.

https://github.com/llvm/llvm-project/pull/113852


More information about the libcxx-commits mailing list