[libcxx-commits] [libcxx] [NFC] Use explicit #include instead of transitive #include (PR #115420)
via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Nov 7 20:33:54 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Peng Liu (winner245)
<details>
<summary>Changes</summary>
The benchmark test currently uses `std::unique_ptr` without explicitly including <memory>. I think we should not rely on transitive inclusion.
---
Full diff: https://github.com/llvm/llvm-project/pull/115420.diff
1 Files Affected:
- (modified) libcxx/test/benchmarks/vector_operations.bench.cpp (+1)
``````````diff
diff --git a/libcxx/test/benchmarks/vector_operations.bench.cpp b/libcxx/test/benchmarks/vector_operations.bench.cpp
index b0dffe35ec6e14..119f9e16dadc6e 100644
--- a/libcxx/test/benchmarks/vector_operations.bench.cpp
+++ b/libcxx/test/benchmarks/vector_operations.bench.cpp
@@ -14,6 +14,7 @@
#include <deque>
#include <functional>
#include <vector>
+#include <memory>
#include "benchmark/benchmark.h"
``````````
</details>
https://github.com/llvm/llvm-project/pull/115420
More information about the libcxx-commits
mailing list