[libcxx-commits] [libcxx] Use explicit #include instead of transitive #include (PR #115420)

Peng Liu via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 7 20:33:20 PST 2024


https://github.com/winner245 created https://github.com/llvm/llvm-project/pull/115420

The benchmark test currently uses `std::unique_ptr` without explicitly including <memory>. I think we should not rely on transitive inclusion. 

>From 21d89ca4b83c26137c4b2710ff77fcd8fdb80ba6 Mon Sep 17 00:00:00 2001
From: Peng Liu <winner245 at hotmail.com>
Date: Thu, 7 Nov 2024 23:28:41 -0500
Subject: [PATCH] Use explicit #include instead of transitive #include

---
 libcxx/test/benchmarks/vector_operations.bench.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libcxx/test/benchmarks/vector_operations.bench.cpp b/libcxx/test/benchmarks/vector_operations.bench.cpp
index b0dffe35ec6e14..119f9e16dadc6e 100644
--- a/libcxx/test/benchmarks/vector_operations.bench.cpp
+++ b/libcxx/test/benchmarks/vector_operations.bench.cpp
@@ -14,6 +14,7 @@
 #include <deque>
 #include <functional>
 #include <vector>
+#include <memory>
 
 #include "benchmark/benchmark.h"
 



More information about the libcxx-commits mailing list