[libcxx-commits] [clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

[Nikita Popov via libcxx-commits]

nikic wrote:

> Yes, that is correct. This patch should be changing your CMake config as well, unless that config is not visible in the monorepo (or if I missed it).

It's out of tree :)

> > And those LIBCXX_ABILIB options are also the defaults, if I'm reading the docs right.
> 
> Not quite. `LIBCXX_ABILIB_FOR_SHARED="shared-libcxxabi"` is the default for the shared library. However for the static library, the default is `LIBCXX_ABILIB_FOR_STATIC="static-libcxxabi"`. That might not be the most useful default (`merged-libcxxabi` would be more useful IMO), but it's the status quo and this patch doesn't change that.

I see, thanks.

I didn't look into this in detail, but the high level design here makes sense to me, and addresses the concerns I had with the previous iteration of the patch.

https://github.com/llvm/llvm-project/pull/112978