[libcxx-commits] [libcxx] [libcxx] Remove xfails due to picolibc's support for char16_t and char32_t (PR #114422)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 1 09:40:38 PDT 2024


ldionne wrote:

@vhscampos It might be sufficient to do this:

```diff
diff --git a/libcxx/utils/ci/build-picolibc.sh b/libcxx/utils/ci/build-picolibc.sh
index 521c1bef9fc7..6913d1d15a1a 100755
--- a/libcxx/utils/ci/build-picolibc.sh
+++ b/libcxx/utils/ci/build-picolibc.sh
@@ -70,7 +70,7 @@ picolibc_build_dir="${build_dir}/picolibc-build"
 mkdir -p "${picolibc_source_dir}"
 mkdir -p "${picolibc_build_dir}"
 # Download a known good version of picolibc.
-picolibc_commit="48fbc2009c6473293d03d5ec6f190565c6223a5c"
+picolibc_commit="f6f68758fe2aa62854f49b90c3daeeb08242b512"
 curl -L "https://github.com/picolibc/picolibc/archive/${picolibc_commit}.zip" --output "${picolibc_source_dir}/picolibc.zip"
 unzip -q "${picolibc_source_dir}/picolibc.zip" -d "${picolibc_source_dir}"
 mv "${picolibc_source_dir}/picolibc-${picolibc_commit}"/* "${picolibc_source_dir}"

```

https://github.com/llvm/llvm-project/pull/114422


More information about the libcxx-commits mailing list