[libcxx-commits] [libcxx] Simplify the __assertion_handler build logic. Be friendly to IDEs. (PR #93333)

[via libcxx-commits]

EricWF wrote:

This change respects your position entirely. I was careful to do that. Could you please do the same for me?

To respect your views, I made sure that this change had no effect on how the library is built and tested.
This change makes all configurations a little simpler. It's clearer where the default file comes from, while allowing users to override it. 

Here's my issue. Developers read, edit, and work with the in-tree headers. Developers like myself often rely on IDE's and other tooling to highlight, autocomplete, diagnose, and otherwise transform the source.  I find these tool assists invaluable. However, almost all tools give up after encountering a missing header.   Because the build overwrites the out-of-tree includes every build, editing out of tree is not a viable solution.

This change alone is enough to better support developer tooling in almost all cases.  

Where can we find consensus? 


https://github.com/llvm/llvm-project/pull/93333