[libcxx-commits] [libcxx] [libcxx] Caches file attributes during directory iteration. (PR #93316)

[via libcxx-commits]

https://github.com/EricWF requested changes to this pull request.

I'm concerned this opens the library up to more TOCTOU attacks. Performance is one consideration, but correctness and security are others. Is it possible for the cached values to become stale/incorrect?

I would like to see some tests that  the cached values are actually correct when entries in the directory change.

https://github.com/llvm/llvm-project/pull/93316