[libcxx-commits] [libcxx] [libcxxabi] [libcxx][libcxxabi] Fix build for OpenBSD (PR #92186)

[Louis Dionne via libcxx-commits]

ldionne wrote:

<img width="325" alt="Screenshot 2024-05-22 at 10 49 38" src="https://github.com/llvm/llvm-project/assets/700834/3dd1cd0a-5f65-47ae-8472-8907c318c408">

This shows what approvals are necessary before landing a patch. The review group must have approved.

> I imagine no one tried to build it on OpenBSD before.

Ok, so then this patch is adding support for a new platform. We have a policy for doing that explained in https://libcxx.llvm.org/#platform-and-compiler-support. As part of our policy, we require CI to be present for all platforms that we officially support.

Since this is not the case right now and it seems that more patches are coming down the pipeline to support OpenBSD, I would like us to add such support before we proceed with any other OpenBSD support patch. If we can't fulfill our support policy, I would ask to revert this patch.

It's unfortunate that this was cherry-picked to the LLVM 18 release since this is definitely not something I'd consider a bugfix, but we can live with that.

https://github.com/llvm/llvm-project/pull/92186