[libcxx-commits] [libcxx] [libcxxabi] [libc++] Fix failures with GCC 14 (PR #92663)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Tue May 21 15:49:29 PDT 2024
================
@@ -1165,6 +1165,10 @@ __gxx_personality_v0(_Unwind_State state,
}
#endif
+_LIBCXXABI_FUNC_VIS void
+__cxa_call_terminate(void*) throw() {
+ std::terminate();
+}
----------------
ldionne wrote:
It looks like this is the commit that introduced this in GCC: https://github.com/gcc-mirror/gcc/commit/2415024e0f81f8c09bf08f947c790b43de9d0bbc
The commit message provides more context. It looks like what we should do here is simply provide `__cxa_call_terminate` in libc++abi unconditionally and have it do what the compiler-generated `__clang_call_terminate` does today (https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/ItaniumCXXABI.cpp#L4757). We should be able to ditch the generation of `__clang_call_terminate` entirely in the future once we only support deployment targets that implement `__cxa_call_terminate` (in a while).
@jyknight does that make sense to you?
https://github.com/llvm/llvm-project/pull/92663
More information about the libcxx-commits
mailing list