[libcxx-commits] [libcxx] [libc++] Use remove_pointer builtin as library traits (PR #91838)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> I don't like that patch. If you want to make it, make it.
> 
> Finally, you will have to add 4x14 lines code at least, see [#91831 (comment)](https://github.com/llvm/llvm-project/issues/91831#issuecomment-2105592054). For other type traits, it can be even more complex.

You're not required to like it, but just saying you don't like it doesn't tell me at all why. 4 lines per type trait really doesn't seem that bad. Also note that there only have to be changes for the transformation type traits, not the value type traits. I'm also not going to write a patch, since I don't have access to GCC 14 yet. You submitted a patch to make changes to libc++. If you don't want to, don't do it. Nobody makes you.

> @philnik777 I contributed to llvm project before such as [d431932](https://github.com/llvm/llvm-project/commit/d431932d3895eaff189cba429289671ff68b26eb) and [0c6fed5](https://github.com/llvm/llvm-project/commit/0c6fed5716c75285181db8a20e5f84ddec11f76a) when llvm still sat in Phabricator. But I don't agree with your way of handling code. If libc++ has different standards with llvm, it makes sense.

You're free to disagree, but please make a point I can respond to instead of just saying that you disagree. _Please_ tell me _why_. Any yes, libc++ is different from other parts of the project. libc++ is a standard library and not a compiler after all.

https://github.com/llvm/llvm-project/pull/91838