[libcxx-commits] [libcxx] WIP - [libc++][functional] P2944R3 (partial): Comparisons for ``reference_wrapper`` (``reference_wrapper`` operators only) (PR #88384)

Hristo Hristov via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 4 10:39:05 PDT 2024


Zingam wrote:

> Your last change misses one change. You were right and `__cpp_lib_reference_wrapper` should indeed be marked as implemented in this patch.
> 
> With that fixed it LGTM.

I didn't bother to set it because I wanted to ask  you about your comment:

https://github.com/llvm/llvm-project/pull/88384#discussion_r1589971027

> This does not implement the proposed resolution of LWG4071. Can you update it to the current proposed resolution? We should also have additonal tests that detect objects that pass this constraint but do not satisfy the `__synth_three_way` concept.

I don't quite understand it: `__synth_three_way` is a function. Did I address your comment by any chance :)

https://github.com/llvm/llvm-project/pull/88384


More information about the libcxx-commits mailing list