[libcxx-commits] [libcxx] [libc++] Split up ABI and platform configuration to their own headers (PR #90863)
via libcxx-commits
libcxx-commits at lists.llvm.org
Fri May 3 15:04:59 PDT 2024
EricWF wrote:
> This kind of issue is less likely to happen when things are split in a logical manner instead of crammed in a file with 1200 lines.
I disagree. But that's OK, we can disagree on that. I'm not going to block this patch based wholly on my opinion here.
Would you mind being explicit about the dependency graph between the various units. It seems to me to be `__config -> (platform.h, abi.h
> For example, we never noticed that the string layout used on arm64 was only enabled for the Clang compiler, as the setting being in the compiler == clang block was probably never intentional.
I see that this underlying issue hasn't been addressed and still exists in this change. What's the plan for addressing it?
Since that bug is the cited motivation for this change, I would like to see how this change would have improved things, which is hard to imagine when the issue remains.
https://github.com/llvm/llvm-project/pull/90863
More information about the libcxx-commits
mailing list