[libcxx-commits] [libcxx] [libc++] Disables -Wweak-vtables diagnostics. (PR #85577)

[Louis Dionne via libcxx-commits]

================
@@ -27,6 +27,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 template <class _Err>
 class bad_expected_access;
 
+_LIBCPP_DIAGNOSTIC_PUSH
+_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wweak-vtables")
----------------
ldionne wrote:

@mordante Is Clang trunk complaining about the vtable of `bad_expected_access<void>` only, or about the one for the base template as well? Cause for the base template we can't do anything, but we could indeed do what @philnik777 said for the `<void>` specialization. We were basically "lazy" when we introduced `bad_expected_access` and decided not to put it in the dylib, but we could have.

https://github.com/llvm/llvm-project/pull/85577