[libcxx-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 26 15:47:24 PDT 2024


================
@@ -234,22 +231,23 @@ export namespace std {
     using std::chrono::zoned_time;
 
     using std::chrono::zoned_seconds;
+#    endif // if 0
 
     // [time.zone.leap], leap second support
     using std::chrono::leap_second;
-#  endif
 
-#  ifdef _LIBCPP_ENABLE_EXPERIMENTAL
     // [time.zone.link], class time_zone_link
     using std::chrono::time_zone_link;
-#  endif
 
-#  if 0
+#    if 0
----------------
h-vetinari wrote:

This is already the state of the `*.inc` files on main (i.e. using `#if 0`). And there's nothing more to track other than whether something is not yet fully implemented (which is already done in various other places). It's a way to keep a full overview of the module definition, while adding minimal overhead for disabling parts that aren't implemented yet.

The key difference IMO is that this is not an _implementation_ that's `#if 0`'d out due bugs or low quality, but just individual lines in a synopsis. It's quite a stretch to call this not appropriate.

https://github.com/llvm/llvm-project/pull/82113


More information about the libcxx-commits mailing list