[libcxx-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 26 11:26:43 PDT 2024


================
@@ -234,22 +231,23 @@ export namespace std {
     using std::chrono::zoned_time;
 
     using std::chrono::zoned_seconds;
+#    endif // if 0
 
     // [time.zone.leap], leap second support
     using std::chrono::leap_second;
-#  endif
 
-#  ifdef _LIBCPP_ENABLE_EXPERIMENTAL
     // [time.zone.link], class time_zone_link
     using std::chrono::time_zone_link;
-#  endif
 
-#  if 0
+#    if 0
----------------
EricWF wrote:

I disagree. 

If you want to ifdef the thing out, please add a meaningful macro name that can be tracked and referenced.

The work you've done creating the list, in order, is not lost. It's just not appropriate to commit to the main branch. Let it live elsewhere in version control until its ready.



https://github.com/llvm/llvm-project/pull/82113


More information about the libcxx-commits mailing list