[libcxx-commits] [libcxx] [libc++] Don't push and pop extensions diagnostics when using clang modules (PR #85917)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 21 20:00:18 PDT 2024


================
@@ -838,21 +838,30 @@ typedef __char32_t char32_t;
 #  define _LIBCPP_CLANG_DIAGNOSTIC_IGNORED_CXX23_EXTENSION _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wc++2b-extensions")
 #endif
 
+#  if !__has_feature(modules)
----------------
ldionne wrote:

Can you please leave a comment behind explaining why we don't do it for modules?

https://github.com/llvm/llvm-project/pull/85917


More information about the libcxx-commits mailing list