[libcxx-commits] [libcxx] [libc++][CI] Reenables the module tests. (PR #85799)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 19 07:46:05 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

<details>
<summary>Changes</summary>

These were disabled due to ODR violations with mixed versions of clang-tidy and the clang libraries. This issue was fixed in e19e8600cf743690e1a23fb8a2b0dfbe2dafe559.

This reverts commit 0bbada93a559b604797fe57978f3eca5e41edaeb.

---
Full diff: https://github.com/llvm/llvm-project/pull/85799.diff


2 Files Affected:

- (modified) libcxx/test/libcxx/module_std.gen.py (-5) 
- (modified) libcxx/test/libcxx/module_std_compat.gen.py (-5) 


``````````diff
diff --git a/libcxx/test/libcxx/module_std.gen.py b/libcxx/test/libcxx/module_std.gen.py
index 5acaa837d37e0a..fc23985caf30de 100644
--- a/libcxx/test/libcxx/module_std.gen.py
+++ b/libcxx/test/libcxx/module_std.gen.py
@@ -16,11 +16,7 @@
 # to be one monolitic test. Since the test doesn't take very long it's
 # not a huge issue.
 
-# WARNING: Disabled at the bottom. Fix this test and remove the UNSUPPORTED line
-# TODO: Re-enable this test once we understand why it keeps timing out.
-
 # RUN: %{python} %s %{libcxx-dir}/utils
-# END.
 
 import sys
 
@@ -39,5 +35,4 @@
 
 
 print("//--- module_std.sh.cpp")
-print('// UNSUPPORTED: clang')
 generator.write_test("std")
diff --git a/libcxx/test/libcxx/module_std_compat.gen.py b/libcxx/test/libcxx/module_std_compat.gen.py
index a502276a1ccfc5..000aa299861220 100644
--- a/libcxx/test/libcxx/module_std_compat.gen.py
+++ b/libcxx/test/libcxx/module_std_compat.gen.py
@@ -16,11 +16,7 @@
 # to be one monolitic test. Since the test doesn't take very long it's
 # not a huge issue.
 
-# WARNING: Disabled at the bottom. Fix this test and remove the UNSUPPORTED line
-# TODO: Re-enable this test once we understand why it keeps timing out.
-
 # RUN: %{python} %s %{libcxx-dir}/utils
-# END.
 
 import sys
 
@@ -40,7 +36,6 @@
 
 
 print("//--- module_std_compat.sh.cpp")
-print("// UNSUPPORTED: clang")
 generator.write_test(
     "std.compat",
     module_c_headers,

``````````

</details>


https://github.com/llvm/llvm-project/pull/85799


More information about the libcxx-commits mailing list